fix(🍏): add explicit header search paths for static frameworks#3904
Open
bonnmh wants to merge 2 commits into
Open
fix(🍏): add explicit header search paths for static frameworks#3904bonnmh wants to merge 2 commits into
bonnmh wants to merge 2 commits into
Conversation
Expo SDK 56 with useFrameworks: 'static' fails to resolve Skia and third_party headers. Add explicit cpp/api and related paths so includes work without relying on recursive wildcards. Fixes Shopify#3895
bonnmh
force-pushed
the
fix/expo-static-frameworks-header-paths
branch
from
03d4148 to
1ffe817
Compare
Contributor
|
#3895 mentions that using the latest Skia version fixes the issue. Can you send me instruction on how I could reproduce the issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expo SDK 56 with useFrameworks: 'static' fails to resolve Skia and third_party headers. Add explicit cpp/api and related paths so includes work without relying on recursive wildcards.
Fixes #3895