Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Automatic filesystem mocks hide file and directory behavior. Filesystem tests must use real temporary files so they can detect incorrect I/O.
WHAT is this pull request doing?
Enable
@shopify/cli/no-filesystem-auto-mocksas an error and replace the seven existing automatic filesystem mocks with temporary files or call-observation spies on real implementations. Dev-session tests also wait for event processing to finish before they check results.The rule covers automatic mocks only. Factory and partial mocks remain outside its scope. It also adds a rule pointer to the filesystem section of the testing guide.
No changeset is needed: this changes internal lint tooling and tests, not CLI behavior.
How to manually test your changes?
In any test file, add
vi.mock('@shopify/cli-kit/node/fs')and run ESLint on that file. The rule reports the automatic mock. A factory mock, such asvi.mock('@shopify/cli-kit/node/fs', async () => ({...})), is not reported.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add