Add a create store option to the app dev store picker - #8397
Open
dmerand wants to merge 2 commits into
Open
Conversation
Assisted-By: devx/389e4e7c-5ebc-4d59-bf3e-d0eb8c0187d3
Assisted-By: devx/4593ba0e-0e3a-4487-a065-4ae504486df8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Stacked PR. Base is
dlm-app-dev-inline-store-creation(#8323), notmain. This PR only shows the store-picker option on top of the inline creation flow that #8323 adds. Do not merge before #8323.WHY are these changes introduced?
Closes shop/issues-develop#23597
#8323 lets
app devcreate a dev store inline, but only when the organization has zero stores. Developers with existing stores still have to leave the CLI to create a new one. Per the command-scope decision, the store picker inapp devshould also offer a "create store" option.WHAT is this pull request doing?
Adds a
Create a new dev storechoice to theapp devstore picker for App Management organizations that already have stores. Selecting it runs the same name/plan/create/poll flow that #8323 added for the zero-store case.StoreCreationModevalue'selection-option'; onlyapp devopts in. All other callers keep the default'disabled', and'when-empty'behavior is unchanged.--storeguidance. One confirmed store still auto-selects, and explicit or cached selection still bypasses the picker.How to test your changes?
app dev --reset. The store picker lists your stores plusCreate a new dev store.app dev --resetagain and pickCreate a new dev store: enter a name, pick a plan, and dev continues on the new store after the success banner.Manual tophat: this picker-entry behavior was tophatted before the stack split, on the pre-split equivalent SHA
4e85e16c(multi-store list with create choice, name/basic plan, single success banner, preview ready, explicit--storeand cached-store bypass, store list stays dev-type, standalonestore create dev --jsonunaffected, cleanup). The current child SHA has not been live-tophatted yet.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add