[Security] Harden LocalStorage file permissions#8039
Conversation
Hardens the LocalStorage class by enforcing 0600 (owner-only) file permissions on the configuration file. This ensures that sensitive data like tokens or preferences are only readable by the current user. Modified: - packages/cli-kit/src/public/node/local-storage.ts: Added ensureRestrictedPermissions method and calls in constructor and mutation methods.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/local-storage.d.ts@@ -41,6 +41,12 @@ export declare class LocalStorage<T extends Record<string, any>> {
* @throws BugError if an unexpected error occurs.
*/
clear(): void;
+ /**
+ * Ensures the configuration file has restricted permissions (0600),
+ * so it's only readable/writable by the current user.
+ * This is important because the configuration file may contain sensitive information.
+ */
+ private ensureRestrictedPermissions;
/**
* Handle errors from config operations.
* If the error is permission-related, throw an AbortError with helpful hints.
|
This PR hardens the
LocalStorageclass by ensuring that the underlying configuration file is created and maintained with restricted permissions (0600). This prevents other users on the same system from reading potentially sensitive configuration data or tokens stored by the CLI.The implementation uses
chmodSyncto set the mode to0o600during initialization and after any operation that might cause the file to be recreated (set,delete,clear).Verification was performed by confirming that configuration files are now created with
0600permissions on a Linux system, whereas they previously defaulted to more permissive modes (e.g.,0664). Existing unit tests forLocalStoragecontinue to pass.PR created automatically by Jules for task 18028481184274082040 started by @gonzaloriestra