Skip to content

[Refactor] Use native timers/promises in sleep#8016

Draft
gonzaloriestra wants to merge 2 commits into
mainfrom
refactor-use-native-timers-promises-17141589781697498983
Draft

[Refactor] Use native timers/promises in sleep#8016
gonzaloriestra wants to merge 2 commits into
mainfrom
refactor-use-native-timers-promises-17141589781697498983

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The sleep utility function in packages/cli-kit was using a manual Promise wrapper around a callback-based setTimeout. Modern Node.js provides a native promisified version of setTimeout in the node:timers/promises module, which is more idiomatic and maintainable.

WHAT is this pull request doing?

  • Refactors the sleep function in packages/cli-kit/src/public/node/system.ts to use setTimeout from node:timers/promises.
  • Adds a unit test for the sleep function in packages/cli-kit/src/public/node/system.test.ts to verify its behavior and ensure correctness.

How to test your changes?

CI

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 17141589781697498983 started by @gonzaloriestra

Refactor the sleep utility function to use the modern setTimeout from
node:timers/promises instead of a manual Promise wrapper.

Added a unit test to verify the functionality and protect against
regressions.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 7, 2026
Refactor the sleep utility function to use the modern setTimeout from
node:timers/promises instead of a manual Promise wrapper.

Added a unit test to verify the functionality and protect against
regressions. verified that CI failures are pre-existing and unrelated
to this change by running tests locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant