[Tests] Refactor doc fetch service tests to remove fs mocks#8015
[Tests] Refactor doc fetch service tests to remove fs mocks#8015gonzaloriestra wants to merge 1 commit into
Conversation
- Remove `vi.mock('@shopify/cli-kit/node/fs')` from `packages/cli/src/cli/services/commands/doc/fetch.test.ts`.
- Use `inTemporaryDirectory` to create a real temporary directory for testing file output.
- Use `await expect(...).resolves` for asynchronous assertions to comply with ESLint rules.
- Verify file creation and content using `fileExists` and `readFile`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
Followed the instructions in
.agents/automated-tasks/tests.mdto replace filesystem mocks with real operations in a temporary directory fordocFetchServicetests inpackages/cli/src/cli/services/commands/doc/fetch.test.ts.Changes:
packages/cli/src/cli/services/commands/doc/fetch.test.ts.writes the document to the output path instead of stdouttest case to useinTemporaryDirectoryandjoinPath.fileExistsandreadFile..resolvesto satisfy linting requirements.PR created automatically by Jules for task 10656394579371662531 started by @gonzaloriestra