[Security] Harden takeRandomFromArray#8013
Conversation
Replaced Math.random() with globalThis.crypto.getRandomValues() in the takeRandomFromArray utility to ensure cryptographically secure random selection. Implemented rejection sampling to eliminate modulo bias, ensuring a uniform distribution across all array elements. Added unit tests to verify correctness.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
takeRandomFromArrayutility was usingMath.random(), which is not cryptographically secure and can be predictable. Additionally, using the modulo operator on a random number without rejection sampling can introduce modulo bias.WHAT is this pull request doing?
Math.random()withglobalThis.crypto.getRandomValues()inpackages/cli-kit/src/public/common/array.ts.takeRandomFromArrayinpackages/cli-kit/src/public/common/array.test.ts.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 5710042040880058116 started by @gonzaloriestra