[Security] Harden takeRandomFromArray with CSPRNG#8003
Conversation
Replaced Math.random() with globalThis.crypto.getRandomValues() in the takeRandomFromArray utility to ensure cryptographic security. Added unit tests to verify the behavior.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Replaced Math.random() with globalThis.crypto.getRandomValues() in the takeRandomFromArray utility and implemented rejection sampling to fix modulo bias. Added unit tests to verify the behavior.
WHY are these changes introduced?
The
takeRandomFromArrayutility usedMath.random(), which is not cryptographically secure. Hardening it with a CSPRNG provides defense-in-depth for this public utility.WHAT is this pull request doing?
Replaces
Math.random()withglobalThis.crypto.getRandomValues()intakeRandomFromArray. Added unit tests for the utility.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 17998295092342495672 started by @gonzaloriestra