Skip to content

fix: stop reporting expected function errors #7316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byrichardpowell merged 3 commits into from
Apr 15, 2026
+14 −7
Merged

fix: stop reporting expected function errors #7316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54cc44d
fix: stop reporting expected errors to Bugsnag
byrichardpowell Apr 15, 2026
f4a1741
Address review: consistent return shape and move test to correct desc…
byrichardpowell Apr 15, 2026
39c7b05
fix: remove extra blank line (prettier)
byrichardpowell Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions packages/cli-kit/src/public/node/error-handler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,15 @@ describe('skips sending errors to Bugsnag', () => {
expect(onNotify).not.toHaveBeenCalled()
expect(mockOutput.debug()).toMatch('Skipping Bugsnag report')
})

test('when error is expected', async () => {
const mockOutput = mockAndCaptureOutput()
const res = await sendErrorToBugsnag(new error.AbortError('In test'), 'expected_error')
expect(res.reported).toEqual(false)
expect(res.unhandled).toBeUndefined()
expect(onNotify).not.toHaveBeenCalled()
expect(mockOutput.debug()).toMatch('Skipping Bugsnag report for expected error')
})
})

describe('sends errors to Bugsnag', () => {
Expand All @@ -200,13 +209,6 @@ describe('sends errors to Bugsnag', () => {
expect(onNotify).toHaveBeenCalledWith(res.error)
})

test('processes AbortErrors as handled', async () => {
const res = await sendErrorToBugsnag(new error.AbortError('In test'), 'expected_error')
expect(res.reported).toEqual(true)
expect(res.unhandled).toEqual(false)
expect(onNotify).toHaveBeenCalledWith(res.error)
})

test.each([null, undefined, {}, {message: 'nope'}])('deals with strange things to throw %s', async (throwable) => {
const res = await sendErrorToBugsnag(throwable, 'unexpected_error')
expect(res.reported).toEqual(false)
Expand Down
5 changes: 5 additions & 0 deletions packages/cli-kit/src/public/node/error-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ export async function sendErrorToBugsnag(
return {reported: false, error, unhandled: undefined}
}

if (exitMode === 'expected_error') {
outputDebug(`Skipping Bugsnag report for expected error`)
return {reported: false, error, unhandled: undefined}
}

// If the error was unexpected, we flag it as "unhandled" in Bugsnag. This is a helpful distinction.
const unhandled = exitMode === 'unexpected_error'

Expand Down
Loading