E2E: temporary time limit bump#7282
Draft
phyllis-sy-wu wants to merge 2 commits intopsyw-0413-E2E-improve-error-context-in-assertionsfrom
Draft
E2E: temporary time limit bump#7282phyllis-sy-wu wants to merge 2 commits intopsyw-0413-E2E-improve-error-context-in-assertionsfrom
phyllis-sy-wu wants to merge 2 commits intopsyw-0413-E2E-improve-error-context-in-assertionsfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
45cdabf to
d872975
Compare
8e705aa to
77e5ea0
Compare
This was referenced Apr 14, 2026
77e5ea0 to
5765d59
Compare
d872975 to
3c85425
Compare
5765d59 to
f45019e
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/node-package-manager.d.ts@@ -68,14 +68,6 @@ export declare function packageManagerFromUserAgent(env?: NodeJS.ProcessEnv): Pa
* @returns The dependency manager
*/
export declare function getPackageManager(fromDirectory: string): Promise<PackageManager>;
-/**
- * Builds the command and argv needed to execute a local binary using the package manager
- * detected from the provided directory or its ancestors.
- */
-export declare function packageManagerBinaryCommandForDirectory(fromDirectory: string, binary: string, ...binaryArgs: string[]): Promise<{
- command: string;
- args: string[];
-}>;
interface InstallNPMDependenciesRecursivelyOptions {
/**
* The dependency manager to use to install the dependencies.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
With per-test store creation (next PR in stack), each test that uses
app devnow creates and tears down a dev store. This adds ~30s per test, pushing the total suite time over the previous 20-minute PlaywrightglobalTimeouton CI with 1 worker.WHAT is this pull request doing?
Bumps
globalTimeoutfrom 20 min to 30 min inplaywright.config.ts. This is temporary — will be reduced when parallel workers (5 workers) are enabled in a future PR, which cuts total suite time significantly.How to test your changes?
pnpm test:e2e # Should complete within 30 min on CI without hitting globalTimeoutChecklist
pnpm changeset add