Skip to content

E2E: temporary time limit bump#7282

Draft
phyllis-sy-wu wants to merge 2 commits intopsyw-0413-E2E-improve-error-context-in-assertionsfrom
psyw-0413-E2E-temporary-time-limit-bump
Draft

E2E: temporary time limit bump#7282
phyllis-sy-wu wants to merge 2 commits intopsyw-0413-E2E-improve-error-context-in-assertionsfrom
psyw-0413-E2E-temporary-time-limit-bump

Conversation

@phyllis-sy-wu
Copy link
Copy Markdown
Contributor

@phyllis-sy-wu phyllis-sy-wu commented Apr 14, 2026

WHY are these changes introduced?

With per-test store creation (next PR in stack), each test that uses app dev now creates and tears down a dev store. This adds ~30s per test, pushing the total suite time over the previous 20-minute Playwright globalTimeout on CI with 1 worker.

WHAT is this pull request doing?

Bumps globalTimeout from 20 min to 30 min in playwright.config.ts. This is temporary — will be reduced when parallel workers (5 workers) are enabled in a future PR, which cuts total suite time significantly.

How to test your changes?

pnpm test:e2e
# Should complete within 30 min on CI without hitting globalTimeout

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

Copy link
Copy Markdown
Contributor Author

phyllis-sy-wu commented Apr 14, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@phyllis-sy-wu phyllis-sy-wu changed the base branch from main to graphite-base/7282 April 14, 2026 02:45
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-temporary-time-limit-bump branch from 8e705aa to 77e5ea0 Compare April 14, 2026 02:45
@phyllis-sy-wu phyllis-sy-wu changed the base branch from graphite-base/7282 to psyw-0413-E2E-improve-error-context-in-assertions April 14, 2026 02:45
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-temporary-time-limit-bump branch from 77e5ea0 to 5765d59 Compare April 14, 2026 04:50
@phyllis-sy-wu phyllis-sy-wu changed the base branch from psyw-0413-E2E-improve-error-context-in-assertions to graphite-base/7282 April 14, 2026 16:48
@phyllis-sy-wu phyllis-sy-wu force-pushed the psyw-0413-E2E-temporary-time-limit-bump branch from 5765d59 to f45019e Compare April 14, 2026 17:11
@phyllis-sy-wu phyllis-sy-wu changed the base branch from graphite-base/7282 to psyw-0413-E2E-improve-error-context-in-assertions April 14, 2026 17:11
@github-actions
Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/node-package-manager.d.ts
@@ -68,14 +68,6 @@ export declare function packageManagerFromUserAgent(env?: NodeJS.ProcessEnv): Pa
  * @returns The dependency manager
  */
 export declare function getPackageManager(fromDirectory: string): Promise<PackageManager>;
-/**
- * Builds the command and argv needed to execute a local binary using the package manager
- * detected from the provided directory or its ancestors.
- */
-export declare function packageManagerBinaryCommandForDirectory(fromDirectory: string, binary: string, ...binaryArgs: string[]): Promise<{
-    command: string;
-    args: string[];
-}>;
 interface InstallNPMDependenciesRecursivelyOptions {
     /**
      * The dependency manager to use to install the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant