Skip to content

DRY up shortcut and link rendering in DevSessionUI#7260

Open
nickwesselman wants to merge 1 commit intonwesselman/dev-footer-hyperlinksfrom
nwesselman/dev-footer-dry-shortcuts
Open

DRY up shortcut and link rendering in DevSessionUI#7260
nickwesselman wants to merge 1 commit intonwesselman/dev-footer-hyperlinksfrom
nwesselman/dev-footer-dry-shortcuts

Conversation

@nickwesselman
Copy link
Copy Markdown
Contributor

@nickwesselman nickwesselman commented Apr 13, 2026

WHY are these changes introduced?

The app dev footer content had an increasing number of redundant checks.

WHAT is this pull request doing?

Proposed update to make the app dev footer more DRY.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

Copy link
Copy Markdown
Contributor Author

nickwesselman commented Apr 13, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nickwesselman nickwesselman changed the base branch from nwesselman/dev-footer-hyperlinks to graphite-base/7260 April 13, 2026 15:10
@nickwesselman nickwesselman marked this pull request as ready for review April 13, 2026 15:20
@nickwesselman nickwesselman requested a review from a team as a code owner April 13, 2026 15:20
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-dry-shortcuts branch from 44a9b4a to 84802e4 Compare April 13, 2026 15:22
@nickwesselman nickwesselman changed the base branch from graphite-base/7260 to nwesselman/dev-footer-hyperlinks April 13, 2026 15:22
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-dry-shortcuts branch from 84802e4 to b127d42 Compare April 13, 2026 15:28
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-hyperlinks branch 2 times, most recently from fe40fdc to 660d519 Compare April 13, 2026 15:30
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-dry-shortcuts branch 2 times, most recently from 42be84b to ed07bb8 Compare April 13, 2026 15:41
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-hyperlinks branch from 660d519 to 880aac9 Compare April 13, 2026 15:41
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-dry-shortcuts branch from ed07bb8 to 99a5c61 Compare April 13, 2026 15:46
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-hyperlinks branch from 880aac9 to 672c0d4 Compare April 13, 2026 15:46
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-dry-shortcuts branch from 99a5c61 to ec24a22 Compare April 13, 2026 16:09
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-hyperlinks branch from 672c0d4 to a8b0bbc Compare April 13, 2026 16:09
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-hyperlinks branch from a8b0bbc to e126d1d Compare April 13, 2026 19:11
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-dry-shortcuts branch from ec24a22 to 710266f Compare April 13, 2026 19:11
Extract devStatusShortcuts array with shortcutLabel, linkLabel, url,
condition, and action fields. Both the keyboard shortcut hints and the
URL list are now rendered by iterating over the same collection,
eliminating duplicated conditions and labels.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-hyperlinks branch from e126d1d to dbabaf1 Compare April 13, 2026 19:19
@nickwesselman nickwesselman force-pushed the nwesselman/dev-footer-dry-shortcuts branch from 710266f to d14eb0a Compare April 13, 2026 19:19
@github-actions
Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/system.d.ts
@@ -87,6 +87,12 @@ export declare function exec(command: string, args: string[], options?: ExecOpti
  * @returns A Promise resolving after the number of seconds.
  */
 export declare function sleep(seconds: number): Promise<void>;
+/**
+ * Check if the terminal supports OSC 8 hyperlinks.
+ *
+ * @returns True if the terminal supports hyperlinks.
+ */
+export declare function terminalSupportsHyperlinks(): boolean;
 /**
  * Check if the standard input and output streams support prompting.
  *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant