Open
Conversation
js-goupil
changed the title
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
alfonso-noriega
approved these changes
Feb 25, 2026
Add supported_features.runs_offline configuration option for UI extensions that enables offline mode. The TOML config uses `runs_offline` but it is transformed to `offline_mode` when sent to the backend API. - Add runs_offline to SupportedFeaturesSchema - Transform runs_offline -> offline_mode in deployConfig for backend - Add offlineMode to dev server payload for local development - Add comprehensive tests for all scenarios Co-authored-by: Cursor <cursoragent@cursor.com>
Update remaining test fixtures to use the new runs_offline field name in the configuration schema. Co-authored-by: Cursor <cursoragent@cursor.com>
js-goupil
force-pushed
the
jsgoupil/add-runs-offline-support
branch
from
448e354 to
dbd1a35
Compare
Backend now accepts runs_offline directly, no need to transform to offline_mode. Pass supported_features through as-is. Co-authored-by: Cursor <cursoragent@cursor.com>
js-goupil
force-pushed
the
jsgoupil/add-runs-offline-support
branch
from
dbd1a35 to
b31410f
Compare
Contributor
Coverage report
Test suite run success3768 tests passing in 1448 suites. Report generated by 🧪jest coverage report action from b31410f |
Contributor
Author
|
@aaronschubert0 I'll merge this once the backend PR hits prod, that way we can tophat this full flow against core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We are renaming offline_mode to runs_offline after some feedback from a GSD review. All of the internal API is left as offline_mode in order to ship this and reduce the amount of friction for now. We can migrate/refactor later if we decide it's worthwhile.
WHAT is this pull request doing?
Just a rename for the developer facing toml
How to test your changes?
supported_features.runs_offlineset totrueorfalsepnpm shopify app dev --path {Path to extension}to run this app locally and deploy the draft to your dev shopMeasuring impact
How do we know this change was effective? Please choose one:
Checklist