Conversation
…assets scripts with multibyte characters
Contributor
Author
|
👋 Hey @Shopify/app-inner-loop, could you please take a look at this when you have a moment? PS: I've proposed #6818 to prevent similar review requests in the future 🙇 |
Contributor
Coverage report
Test suite run success3772 tests passing in 1453 suites. Report generated by 🧪jest coverage report action from 6a7bfce |
gonzaloriestra
approved these changes
Feb 12, 2026
EvilGenius13
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When hot-reloading compiled JS generated from
{% javascript %}blocks, the responseContent-Lengthheader could be computed using the string character count rather than the UTF‑8 byte length. This becomes incorrect as soon as the output contains multi-byte characters (e.g., an em dash—).WHAT is this pull request doing?
This PR updates the compiled_assets script response path to set
content-lengthbased on the UTF‑8 byte length.How to test your changes?
shopify theme devwith a snippet like this:Post-release steps
n/a
Measuring impact
Checklist