Closed
Conversation
Contributor
Unused exports (1)
|
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationspackages/cli-kit/dist/private/node/session/mock-auth.d.tsimport { IdentityToken, Session } from './schema.js';
interface MockUserResponse {
uuid: string;
expires_at: string;
id_token: string;
access_token: string;
refresh_token: string;
last_login: string;
scope: string;
userinfo: {
email: string;
email_verified: boolean;
given_name: string;
family_name: string;
name: string;
picture: string;
zoneinfo: string;
locale: string;
permissions: string[];
okta_id: string | null;
updated_at: string;
created_at: string;
};
}
export declare function shouldUseMockAuth(): boolean;
export declare function fetchMockUser(scopes: string[]): Promise<MockUserResponse>;
export declare function buildMockIdentityToken(mockUser: MockUserResponse, scopes: string[]): IdentityToken;
export declare function buildMockSession(mockUser: MockUserResponse, scopes: string[]): Session;
export {};
Existing type declarationspackages/cli-kit/dist/public/node/vendor/dev_server/network/host.d.ts@@ -1,2 +1 @@
-export declare function getIpFromHosts(hostname: string): string;
-export declare function TEST_ClearCache(): void;
\ No newline at end of file
+export declare function getIpFromHosts(hostname: string): string;
\ No newline at end of file
packages/cli-kit/dist/public/node/vendor/dev_server/network/index.d.ts@@ -5,5 +5,4 @@ export interface ConnectionArguments {
port: number;
timeout?: number;
}
-export declare function assertConnectable(options: ConnectionArguments): void;
-export declare function TEST_testResetCheckPort(): void;
\ No newline at end of file
+export declare function assertConnectable(options: ConnectionArguments): void;
\ No newline at end of file
|
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3355 tests passing in 1372 suites. Report generated by 🧪jest coverage report action from 7f09479 |
Contributor
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist