Fix: no-output timeout runs hanging tests + Refactor: Improve bitrise e2e output - #699
Open
kieran-osgood-shopify wants to merge 1 commit into
Open
Fix: no-output timeout runs hanging tests + Refactor: Improve bitrise e2e output#699kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kieran-osgood-shopify
force-pushed
the
e2e-failed-hang
branch
2 times, most recently
from
August 28, 2026 09:54
7d27781 to
22ea35e
Compare
kieran-osgood-shopify
force-pushed
the
e2e-failed-hang
branch
from
September 1, 2026 11:51
22ea35e to
1a874e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: no-output timeout runs hanging tests
What changes are you making?
I noticed that on occasion if all tests fail or pass for a given suite, e.g. Swift or React Native, what will happen is the bitrise job may hang, polling is checking for a passed/failed status, so if they all report passed close to each other they move to a new state 'completed'

In this case the Kotlin tests all failed due to a browser stack flake where a retry passed
We now check for the additional state of "completed"
Refactor: Improve bitrise e2e output- #699
Additionally I improved the formatting of the bitrise output so that going forwards these bitrise runs will output more information currently they are only output in the URL after success or failure or timeout which means you couldn't look into an app of running sweet until it had finished
How to test
Watch this bitrise run: https://github.com/Shopify/checkout-kit/pull/699/checks?check_run_id=98477125606
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.