fix(dev): bash 3.2 compatibility for dev-instance-manager.sh#268
Merged
fix(dev): bash 3.2 compatibility for dev-instance-manager.sh#268
Conversation
… macOS compatibility The dev-instance-manager.sh script used `declare -A` (associative arrays) which requires bash 4+. macOS ships with bash 3.2 by default, causing `just dev` to fail with "unbound variable" errors. Replace the associative array with plain variables and a case statement to ensure compatibility across all bash versions. Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
declare -A(associative arrays, bash 4+ only) with plain variables and acasestatement inscripts/dev-instance-manager.shmacOS Tahoe Version 26.2) ships with bash 3.2 by default, which causedjust devto fail withunbound variableerrorsResolves ENG-177
Test plan
just devon macOS with default bash 3.2 and confirm it starts without errorsjust devon a system with bash 5+ and confirm it still works