fix : when importing the workflow, it automatically check if secret exist.#258
Open
krishna9358 wants to merge 1 commit intomainfrom
Open
fix : when importing the workflow, it automatically check if secret exist.#258krishna9358 wants to merge 1 commit intomainfrom
krishna9358 wants to merge 1 commit intomainfrom
Conversation
…s for the secret Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
|
This PR solves the problem well! One minor UX improvement: show a toast notification when invalid secret references are removed. Currently they're only logged to console, leaving users confused why fields appear empty. A simple |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s for the secret
Summary
When you export a workflow from one environment and import it into another, the Secret IDs (references to secure credentials) travel with the JSON file. available in the new environment.
If the secret exists: It works fine.
If the secret is missing: The component would still hold onto that old "Reference ID," causing the UI to show a broken or confusing state where it looks like a secret is selected but it's actually invalid (or just a random ID string).
The Solution
We implemented a validation step during the import process in useWorkflowImportExport.ts
Testing
bun run testbun run lintbun run typecheckDocumentation
docs/guide.md) or checked that no updates are needed..ailogs when applicable.