add real coverage for IngestAgent's config and dependency resolution - #384
Merged
Merged
Conversation
ingest.go had zero tests. covered the validation gates that fire before any real infra spins up: missing config file, invalid JSON, an unknown target agent ID, and an embedder pointing at a dependency agent that doesn't exist inline or on disk. left the actual DB/vector ingestion path alone since exercising it needs real infra setup, noted as a follow-up. etl coverage 24.9% -> 35.0%. Claude-Session: https://claude.ai/code/session_01ABxAejDCQZhXXLwCjTEtoc
gerardrecinto
added a commit
that referenced
this pull request
Sep 20, 2026
…384) ingest.go had zero tests. covered the validation gates that fire before any real infra spins up: missing config file, invalid JSON, an unknown target agent ID, and an embedder pointing at a dependency agent that doesn't exist inline or on disk. left the actual DB/vector ingestion path alone since exercising it needs real infra setup, noted as a follow-up. etl coverage 24.9% -> 35.0%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ingest.go had zero tests. covered the validation gates that fire before any real infra spins up: missing config file, invalid JSON, an unknown target agent ID, and an embedder pointing at a dependency agent that doesn't exist inline or on disk. the actual DB/vector ingestion path is untouched since exercising it needs real infra setup (embedder, vector DB, transaction) - a candidate for a future pass, not this one. etl coverage 24.9% -> 35.0%.