add real coverage for RunWorkflow's step dispatch and validation - #383
Merged
Merged
Conversation
zero tests touched workflow.go. wrote 8 covering the actual failure modes a bad workflow file hits: missing file, invalid JSON, an unknown step type, prepare steps missing url or out, an ingest step missing config, an ingest step's underlying failure getting wrapped with the step's name, and confirming a workflow stops at its first failing step instead of running the rest. etl coverage 14.0% -> 24.9%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the ai/etl coverage pass from the previous PR. workflow.go had zero tests before this.
8 tests covering the real failure modes a bad workflow file hits: a missing file, invalid JSON, an unknown step type, a prepare step missing url or out (each checked separately), an ingest step missing config, confirming an ingest step's underlying failure gets wrapped with the step's name (proves dispatch actually reaches IngestAgent, not just the validation gate above it), and confirming a workflow stops at its first failing step instead of running the rest.
ai/etl coverage: 14.0% -> 24.9%. Build+vet+gofmt+test clean.