add real coverage for PrepareDoctorDataset, ai/etl was at 0.8% - #382
Merged
Merged
Conversation
zero tests touched doctor.go at all. wrote 3 against a real local httptest server (not a mock behind an interface, an actual http round trip): CSV parsing into a full agent.Config with correct field values, the blank-disease-row-gets-skipped behavior, underscore-to- space symptom cleanup, sequential ID generation across rows, a 500 response failing CSV header parsing, and an unreachable address failing the download itself. etl package coverage 0.8% -> 14.0%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pivoted from staticcheck (SA4006/U1000 are fully exhausted across the whole codebase now) to real coverage numbers. ai/etl sat at 0.8%, and doctor.go had zero tests touching it at all despite real, meaningful parsing logic (CSV row extraction, symptom text cleanup, sequential ID generation, full agent.Config assembly).
3 tests against a real local httptest.Server, not a mock behind an interface, an actual HTTP round trip through http.Get:
ai/etl coverage: 0.8% -> 14.0%. Build+vet+gofmt+test clean.