drop 5 dead focused_context.go helpers, a self-contained unwired chain plus one orphan - #380
Merged
Merged
Conversation
…n plus one orphan isOnlyLayer1: standalone predicate, no live caller, checked isCrossDomain's call sites for anything similar, nothing wires this one in. trimManualSection, extractManualSection, buildCompactStoresToolContext, trimStoresManualForCombinedContext: only call each other, none reachable from outside the cluster. Grepped for any 'CombinedContext' or 'StoresManual' naming anywhere else in the codebase, zero hits - this whole chain was built and never wired to anything.
Gemini PR ReviewThis diff primarily consists of the removal of several functions (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of tonight's U1000 pile in ai/agent.
isOnlyLayer1: standalone predicate, no live caller anywhere. Checked isCrossDomain's call sites (the live sibling right next to it) for anything similar that should be wired to it instead, nothing does.
trimManualSection, extractManualSection, buildCompactStoresToolContext, trimStoresManualForCombinedContext: these four only call each other in a chain, none reachable from anything outside the cluster. Grepped for 'CombinedContext' or 'StoresManual' anywhere else in the codebase, zero hits - this whole chain was built and never wired to a real caller.
Build+vet+gofmt+test clean. This closes out the U1000 sweep across ai/agent from tonight's staticcheck pass - remaining known item is the copilottools.space.go Space CRUD tool family, already flagged in earlier PRs as needing explicit sign-off since it's feature-sized, not a quick cleanup.