Skip to content

drop 7 dead copilot.go methods, all superseded by a live sibling #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gerardrecinto merged 1 commit into from
Sep 19, 2026
Merged

drop 7 dead copilot.go methods, all superseded by a live sibling #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
194 changes: 0 additions & 194 deletions ai/agent/copilot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package agent
import (
"bytes"
"context"
"crypto/sha256"
"encoding/json"
"flag"
"fmt"
Expand All @@ -21,7 +20,6 @@ import (
"github.com/sharedcode/joltrin/ai"
"github.com/sharedcode/joltrin/ai/agent/parser"
"github.com/sharedcode/joltrin/ai/database"
"github.com/sharedcode/joltrin/ai/embed"
"github.com/sharedcode/joltrin/ai/generator"
"github.com/sharedcode/joltrin/ai/internal/logsafe"
"github.com/sharedcode/joltrin/ai/memory"
Expand Down Expand Up @@ -479,23 +477,6 @@ func normalizeMRUScope(scope string) string {
}
}

func (a *CopilotAgent) clearMRUCategory(category string) {
if a.service == nil || a.service.session == nil {
return
}
sess := a.service.session
sess.MRUMu.Lock()
defer sess.MRUMu.Unlock()

filtered := sess.MRU[:0]
for _, item := range sess.MRU {
if item.Category != category {
filtered = append(filtered, item)
}
}
sess.MRU = filtered
}

func (a *CopilotAgent) clearMRUBySourceAndScope(source string, scope string) {
if a.service == nil || a.service.session == nil {
return
Expand Down Expand Up @@ -1340,32 +1321,6 @@ func (a *CopilotAgent) evaluateRoutingGates(ctx context.Context, query string, g
return a.tryColdStartBasedRouting(ctx, query, gen, isTest)
}

func (a *CopilotAgent) renderToolDefinitionContext(title string, toolNames []string) string {
if a == nil || a.registry == nil || strings.TrimSpace(title) == "" {
return ""
}
var lines []string
for _, name := range toolNames {
name = strings.TrimSpace(name)
if name == "" {
continue
}
toolDef, ok := a.registry.Get(name)
if !ok {
continue
}
description := strings.Join(strings.Fields(strings.TrimSpace(toolDef.Description)), " ")
if description == "" {
continue
}
lines = append(lines, fmt.Sprintf("- %s: %s", toolDef.Name, description))
}
if len(lines) == 0 {
return ""
}
return title + "\n" + strings.Join(lines, "\n")
}

func (a *CopilotAgent) buildStoresToolDescriptionContext() string {
return strings.Join([]string{
"Structured Context: Stores Tools",
Expand Down Expand Up @@ -1632,10 +1587,6 @@ func (a *CopilotAgent) updateClarificationState(ctx context.Context, query strin
}
}

func summarizeAskOutcomeMRU(ctx context.Context, query string, finalText string, toolCalls []ai.ToolCall, outcomeFacts []string) string {
return renderAskOutcomeMRUItems(buildAskOutcomeMRUItems(ctx, query, finalText, toolCalls, outcomeFacts, nil))
}

func buildAskOutcomeMRUItems(ctx context.Context, query string, finalText string, toolCalls []ai.ToolCall, outcomeFacts []string, carryoverState *ai.CarryoverState) []MRUItem {
query = askOutcomeQueryForPersistence(ctx, query)
query = compactMRUText(query, 180)
Expand Down Expand Up @@ -2202,11 +2153,6 @@ func (a *CopilotAgent) handleSlashCommand(ctx context.Context, query string, gen
return false, "", nil
}

func (a *CopilotAgent) resolvePersona(ctx context.Context) string {
persona, _ := a.resolvePersonaWithMetadata(ctx)
return persona
}

func personaSourceCacheKey(agentID string) string {
return personaSourceMRUCategoryPrefix + agentID
}
Expand Down Expand Up @@ -2265,34 +2211,6 @@ func (a *CopilotAgent) resolvePersonaWithMetadata(ctx context.Context) (string,
return persona, personaFromKB
}

func (a *CopilotAgent) getScriptToolsPrompt(ctx context.Context) string {
toolsDef := ""
if a.systemDB != nil {
if tx, err := a.systemDB.BeginTransaction(ctx, sop.ForReading); err == nil {
if store, err := a.systemDB.OpenModelStore(ctx, "scripts", tx); err == nil {
if names, err := store.List(ctx, ai.DefaultScriptCategory); err == nil {
for _, name := range names {
var script ai.Script
if err := store.Load(ctx, ai.DefaultScriptCategory, name, &script); err == nil {
argsSchema := "()"
if len(script.Parameters) > 0 {
var params []string
for _, p := range script.Parameters {
params = append(params, fmt.Sprintf("%s: string", p))
}
argsSchema = fmt.Sprintf("(%s)", strings.Join(params, ", "))
}
toolsDef += fmt.Sprintf("- %s: %s %s\n", name, script.Description, argsSchema)
}
}
}
}
tx.Commit(ctx)
}
}
return toolsDef
}

// citationLabel returns a short, stable identifier for a retrieved
// knowledge-base hit, suitable for an inline "[source: X]" citation in the
// model's context so an answer built from it can point back to exactly
Expand Down Expand Up @@ -2950,70 +2868,6 @@ func (a *CopilotAgent) InitializePhysicalMemory(ctx context.Context) error {
return nil
}

func (a *CopilotAgent) logThought(ctx context.Context, query string, toolsExecuted string, outcome string) {
if a.systemDB == nil {
return
}

if a.Memory == nil {
return
}
a.Memory.BindSession(ctx)
kbName := a.Memory.LongTermMemoryName()

var embedder ai.Embeddings
if a.service != nil && a.service.Domain() != nil && a.service.Domain().Embedder() != nil {
embedder = a.service.Domain().Embedder()
}
if embedder == nil {
return
}

status := "Success"
thought := fmt.Sprintf("Intent: %s\nAST: %s\nStatus: %s\nOutcome: %s\n", query, toolsExecuted, status, outcome)

go func() {
embedCtx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()

vecs, err := embed.DocumentTexts(embedCtx, embedder, []string{thought})
if err != nil || len(vecs) == 0 {
return
}
vec := vecs[0]

tx, err := a.systemDB.BeginTransaction(embedCtx, sop.ForWriting)
if err != nil {
return
}

kb, err := a.systemDB.OpenKnowledgeBase(embedCtx, kbName, tx, a.brain, embedder, false, true)
if err != nil {
tx.Rollback(embedCtx)
return
}

hash := sha256.Sum256([]byte(thought))
itemID := fmt.Sprintf("%x", hash)

payload := map[string]any{
"id": itemID,
"intent": query,
"ast": toolsExecuted,
"status": status,
"outcome": outcome,
"ts": time.Now().UnixMilli(),
"type": "episode",
}
if err := kb.IngestThought(embedCtx, thought, "", "System", vec, payload); err != nil {
tx.Rollback(embedCtx)
return
}
tx.Commit(embedCtx)
log.Debug("Active Memory: Episode logged successfully", "temp_id", itemID)
}()
}

// Execute executes the requested tool against the session payload.
func (a *CopilotAgent) Execute(ctx context.Context, toolName string, args map[string]any) (string, error) {
resolvePayloadTx := func(payload *ai.SessionPayload, targetDB string) sop.Transaction {
Expand Down Expand Up @@ -3553,54 +3407,6 @@ func (a *CopilotAgent) runScript(ctx context.Context, name string, script ai.Scr
return sb.String(), nil
}

func (a *CopilotAgent) runScriptRaw(ctx context.Context, script ai.Script, args map[string]any) (string, error) {
// Scope for template resolution
scope := make(map[string]any)
for k, v := range args {
scope[k] = v
}

var lastResult string

for i, step := range script.Steps {
if step.Type == "command" {
// Resolve args
resolvedArgs := make(map[string]any)
for k, v := range step.Args {
if strVal, ok := v.(string); ok {
resolvedArgs[k] = resolveTemplate(strVal, scope)
} else {
resolvedArgs[k] = v
}
}

// Handle Database Override
stepCtx := ctx
if step.Database != "" {
if p := ai.GetSessionPayload(ctx); p != nil {
// Clone payload to update CurrentDB for this step only
newPayload := *p
newPayload.CurrentDB = step.Database
// Clear transaction if switching DB, as the existing transaction is bound to the old DB
if p.CurrentDB != step.Database {
newPayload.Transaction = nil
}
stepCtx = context.WithValue(ctx, SessionPayloadKey, &newPayload)
}
}

res, err := a.Execute(stepCtx, step.Command, resolvedArgs)
if err != nil {
if !step.ContinueOnError || shouldShortCircuitScriptOnError(step.Command, resolvedArgs, err) {
return "", fmt.Errorf("step %d (%s) failed: %w", i+1, step.Command, err)
}
}
lastResult = res
}
}
return lastResult, nil
}

func resolveTemplate(tmplStr string, scope map[string]any) string {
if tmplStr == "" {
return ""
Expand Down
Loading