drop 5 more dead U1000 items: orphaned wrappers, an unused type, a debug helper - #378
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five more from the pile, three different flavors of dead:
normalizeCompatibilityConditionMap and normalizeCompatibilityConditionMapWithQuery (atomic_engine_part3.go): both thin wrappers around normalizeCompatibilityConditionMapWithQueryAndAliases, which IS called directly elsewhere in the same file. The generalized function absorbed the wrappers' job when aliases/storeFields support got added, and nobody deleted the now-redundant simpler entry points.
progressSink (engine_native.go): a func(string) type alias with zero references anywhere, not even a variable declared with it.
isRoutedAskContext (engine_native.go): pulls RoutingGate out of the session payload's Variables map, zero callers. Checked for duplicate inline logic doing the same context-based lookup elsewhere - every other RoutingGate access already has the struct in hand directly, different access pattern, no real duplication to fix.
getMapKeys (copilottools.join_execution_extras.go): its own comment says it, 'Helper for debugging which keys exist,' zero callers.
Build+vet+gofmt+test clean.