drop mapToStruct and spaceResultToJSON, both dead with no duplicate call sites - #377
Merged
Merged
Conversation
Gemini PR ReviewThe diff removes two helper functions ( Assuming these functions were either unused or their functionality has been correctly refactored and replaced elsewhere in the codebase, this diff looks good.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two more from the U1000 pile.
mapToStruct (api_core.go): a JSON-roundtrip map-to-struct helper marked 'for adapters,' zero callers. Checked whether any other code does the same marshal/unmarshal pattern inline that should be wired to it instead - found one similar-looking spot (expandNativePromptArgs in engine_native.go) but it's a map-to-map normalization with different fallback semantics, not the same thing, no real duplication to fix.
spaceResultToJSON (api_space.go): a struct-to-JSON-string helper marked 'for backward compatibility,' zero callers, and the only json.Marshal call in the whole file is its own.
Both removed along with the now-unused encoding/json imports in each file. Build+vet+gofmt+test clean.