drop toolSwitchDatabase and tryPathStyleRouting, both superseded and dead - #376
Merged
Merged
Conversation
gerardrecinto
deleted the
kill-superseded-routing-and-db-switch-tool
branch
September 19, 2026 22:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two more from the same U1000 pile, same story both times.
toolSwitchDatabase: never registered via RegisterWithUI, zero callers. The /switch_database slash command in service.session.go already reimplements the same db-existence check and context switch inline, superseding this without removing it.
tryPathStyleRouting: sits among sibling tryPrefixBasedRouting/tryAskContinuationBasedRouting in copilot_routing.go, but grepping the actual dispatcher in copilot.go shows only the other two ever get called. This one dropped out of the dispatch chain at some point without anyone deleting it.
Both zero references anywhere, tests included. Build+vet+gofmt+test clean.