Conversation
Delete benchmarks/benchmark_lib.sh and move its behavior into the container-side Python package infx/bench (stdlib only, Python 3.10): wait, monitor, fixed-seq, agentic and eval commands behind one `python3 -m infx.bench` entrypoint, with shared process, readiness and input helpers. srt entry scripts become thin shims; recipe paths are unchanged. Also removes SWE-bench Lite/Modal, the unreachable llm-d lane and amd_utils/server_sglang.sh, and moves AgentX single-concurrency validation into LaunchRequest. 中文:用 infx.bench 包替换 benchmark_lib.sh。删除 benchmark_lib.sh,将其功能迁移到容器内运行的 Python 包 infx/bench(仅依赖标准库,兼容 Python 3.10),通过统一的 `python3 -m infx.bench` 入口提供 wait、monitor、fixed-seq、agentic 与 eval 命令。srt 入口脚本改为轻量封装,recipe 路径保持不变。同时移除 SWE-bench Lite/Modal、不可达的 llm-d 流水线与 amd_utils/server_sglang.sh,并将 AgentX 单并发校验移至 LaunchRequest。
Contributor
|
Thanks for the contribution!
中文感谢你的贡献!
|
Main removed the legacy AMD/TileRT launch lanes, so the code only they used goes too: server_watch, agentic --server-pid, the monitor command and --require-vendor, fixed-seq point mode, and the native power collector scripts. Ports main's lib changes: the multi-node sweep honors CLIENT_BACKEND, BENCHMARK_SERVED_MODEL_NAME and NUM_PROMPTS, and the lm-eval native context reads config.json before transformers. New recipe setup scripts source check_env.sh.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes
benchmarks/benchmark_lib.shand moves its behavior intoinfx/bench/, a container-side package (stdlib only, Python 3.10) behind one entrypoint:python3 -m infx.bench {wait,monitor,fixed-seq,agentic,eval}.proc.py(exit statuses, calls, tee, signal relay/defer, PYTHONPATH),server.py(readiness),env.py(inputs,BenchErrorreported as oneERROR:line).infx/launch.benchmarks/check_env.shkeepscheck_env_varsfor workflows, hooks and legacy lanes.Removed
amd_utils/server_sglang.sh.LaunchRequest.Behavior changes
profile.ymlrelay steps are now dead).meta_env.jsonwith batchedEVAL_CONC, vendor failure writers on Python 3.10, SPEED-Bench aborting on the first dead server.PYTHONSAFEPATHno longer leaks into children (would breakamd-smi).Verification
bash -non every changed script.