fix: allow all-evals sweep artifact reuse#1892
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
all-evalsto use/reuse-sweep-runevals-onlyreuse-incompatibleTesting
uv run --python 3.11 --with pytest --with pyyaml --with pydantic python -m pytest utils/test_find_reusable_sweep_run.py utils/changelog_gate_tests/test_run_sweep_gating.py utils/changelog_gate_tests/test_validate_perf_changelog.py -quv run --python 3.11 --with pytest --with pyyaml --with pydantic python -m pytest utils/changelog_gate_tests/ -qactionlint .github/workflows/run-sweep.ymlbash -n utils/merge_with_reuse.shNote
Medium Risk
Changes CI merge-time sweep reuse gating and the supported merge helper path; wrong policy could skip needed benchmarks or accept stale artifacts, though
evals-onlyremains blocked and tests encode the new rules.Overview
Full-sweep PRs with the
all-evalsmodifier can now use/reuse-sweep-runandmerge_with_reuse.sh, instead of being treated likeevals-onlyruns that must re-benchmark.The
reuse-sweep-gatejob inrun-sweep.ymlno longer blocks on theall-evalslabel—onlyevals-only(including PRs with both modifiers) still skips the reuse gate and cannot reuse artifacts.find_reusable_sweep_run.pydefaults--reuse-incompatible-labeltoevals-onlyonly, and the merge helper drops its early exit forall-evals.AGENTS.md and
.github/workflows/README.mddocument the split:all-evalsfull sweeps are reusable;evals-onlyruns are not. Gating and reuse tests are updated to match (e.g.full-sweep-enabled+all-evals+ authorized reuse now skips setup).Reviewed by Cursor Bugbot for commit a821264. Bugbot is set up for automated code reviews on this repo. Configure here.