-
Notifications
You must be signed in to change notification settings - Fork 206
[NV] update B300 disagg recipes #1887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
biswapanda
wants to merge
27
commits into
SemiAnalysisAI:main
Choose a base branch
from
biswapanda:pr-1787-latest--update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
b506cd4
[NV] Add MiniMax M3 B300 Dynamo vLLM recipes
Oseltamivir 84a023a
chore: update MiniMax M3 B300 container
Oseltamivir b09bc78
chore: update changelog PR link
Oseltamivir 86da150
Update perf-changelog.yaml
Oseltamivir f5727c2
Update perf-changelog.yaml
Oseltamivir 3b6dad4
fix(vllm): patch MiniMax M3 MSA contiguity
Oseltamivir 71ba2ea
fix(recipes): align MiniMax M3 parallel settings
Oseltamivir b859a0b
fix(vllm): backport MiniMax M3 eval fixes
Oseltamivir 2d408e4
ci(sweep): enable full MiniMax M3 validation
Oseltamivir 3956aee
perf(vllm): right-size MiniMax M3 low concurrency
Oseltamivir 33fe6a9
Merge remote-tracking branch 'origin/main' into pr-1787-latest
Oseltamivir 77c6391
Merge branch 'main' into pr-1787-latest
Oseltamivir b99d3c9
perf(vllm): colocate MiniMax M3 TP4 workers
Oseltamivir d2347aa
fix(runner): exclude faulty B300 RDMA node
Oseltamivir 8ace2e9
fix(runner): verify B300 node exclusion
Oseltamivir 884ff12
fix(runner): check generated B300 sbatch script
Oseltamivir 3ae240b
ci(sweep): validate B300 node exclusion
Oseltamivir 9751d93
Merge remote-tracking branch 'origin/main' into pr-1787-latest
Oseltamivir 03d27e7
refactor(vllm): trim MiniMax M3 runtime patches
Oseltamivir 826a64e
Merge branch 'main' into pr-1787-latest
Oseltamivir aec850f
Merge branch 'main' into pr-1787-latest
Oseltamivir 37d5e2c
Update MiniMax M3 B300 Dynamo vLLM recipes
biswapanda adbe614
fix
biswapanda fe0eda5
update to flashinfer
biswapanda 0a751a7
prune non-pareto
biswapanda d08cc43
Merge branch 'main' into pr-1787-latest--update
Ankur-singh b2e71c8
clean up nvidia-master
biswapanda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
benchmarks/multi_node/srt-slurm-recipes/configs/minimax-m3-vllm-fixes.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| python3 - <<'PYEOF' | ||
| from importlib.util import find_spec | ||
| from pathlib import Path | ||
|
|
||
| spec = find_spec("vllm") | ||
| if not spec or not spec.origin: | ||
| raise RuntimeError("vllm is not installed") | ||
| root = Path(spec.origin).parent | ||
| patches = { | ||
| root / "models/minimax_m3/nvidia/sparse_attention_msa.py": [ | ||
| ( | ||
| " prefill_topk = topk[:, nd:num_tokens, :]\n", | ||
| " prefill_topk = topk[:, nd:num_tokens, :].contiguous()\n", | ||
| ), | ||
| ], | ||
| root / "distributed/kv_transfer/kv_connector/v1/nixl/base_worker.py": [ | ||
| ( | ||
| " for i, local_len in enumerate(self.block_len_per_layer):\n", | ||
| " total_kv_heads = self.transfer_topo.total_num_kv_heads\n" | ||
| " local_heads = self.transfer_topo.local_physical_heads\n" | ||
| " remote_heads = max(1, total_kv_heads // remote_tp_size)\n" | ||
| " for i, local_len in enumerate(self.block_len_per_layer):\n", | ||
| ), | ||
| ( | ||
| "remote_len == (local_len * tp_ratio) // block_size_ratio,", | ||
| "remote_len == (local_len * remote_heads // local_heads) " | ||
| "// block_size_ratio,", | ||
| ), | ||
| ( | ||
| "remote_len == local_len // (-tp_ratio),", | ||
| "remote_len == local_len * remote_heads // local_heads,", | ||
| ), | ||
| ], | ||
| } | ||
| for path, edits in patches.items(): | ||
| source = path.read_text() | ||
| for old, new in edits: | ||
| if new in source: | ||
| continue | ||
| if source.count(old) != 1: | ||
| raise RuntimeError(f"missing or ambiguous patch anchor in {path}") | ||
| source = source.replace(old, new, 1) | ||
| path.write_text(source) | ||
| PYEOF |
79 changes: 79 additions & 0 deletions
79
...marks/multi_node/srt-slurm-recipes/vllm/minimax-m3/b300-fp8/1k1k/1p1d-dep2-tep8-1k1k.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| name: "minimax-m3-vllm-disagg-b300-1p1d-fp8-dep2-tep8-1k1k" | ||
|
|
||
| model: | ||
| path: "MiniMaxAI/MiniMax-M3-MXFP8" | ||
| container: "vllm/vllm-openai:minimax-m3-0618-x86_64-cu130" | ||
| precision: "fp8" | ||
|
|
||
| resources: | ||
| gpu_type: "b300" | ||
| gpus_per_node: 8 | ||
| prefill_nodes: 1 | ||
| decode_nodes: 1 | ||
| prefill_workers: 1 | ||
| decode_workers: 1 | ||
| gpus_per_prefill: 2 | ||
| gpus_per_decode: 8 | ||
|
|
||
| dynamo: | ||
| install: true | ||
| version: 1.3.0.dev20260614 | ||
|
|
||
| frontend: | ||
| type: dynamo | ||
| enable_multiple_frontends: false | ||
|
|
||
| backend: | ||
| type: vllm | ||
| connector: null | ||
|
|
||
| prefill_environment: | ||
| UCX_TLS: "cuda_copy,rc" | ||
| VLLM_FLOAT32_MATMUL_PRECISION: "high" | ||
|
|
||
| decode_environment: | ||
| UCX_TLS: "cuda_copy,rc" | ||
| VLLM_FLOAT32_MATMUL_PRECISION: "high" | ||
|
|
||
| vllm_config: | ||
| prefill: | ||
| tensor-parallel-size: 1 | ||
| data-parallel-size: 2 | ||
| data-parallel-rpc-port: 13345 | ||
| enable-expert-parallel: true | ||
| trust-remote-code: true | ||
| no-enable-prefix-caching: true | ||
| kv-transfer-config: '{"kv_connector": "NixlConnector", "kv_role": "kv_both"}' | ||
| block-size: 128 | ||
| gpu-memory-utilization: 0.90 | ||
| max-model-len: 2304 | ||
| language-model-only: true | ||
| stream-interval: 32 | ||
| max-cudagraph-capture-size: 2048 | ||
| max-num-batched-tokens: 2048 | ||
|
|
||
| decode: | ||
| tensor-parallel-size: 8 | ||
| enable-expert-parallel: true | ||
| trust-remote-code: true | ||
| no-enable-prefix-caching: true | ||
| kv-transfer-config: '{"kv_connector": "NixlConnector", "kv_role": "kv_both"}' | ||
| block-size: 128 | ||
| gpu-memory-utilization: 0.90 | ||
| max-model-len: 2304 | ||
| language-model-only: true | ||
| stream-interval: 32 | ||
| max-num-seqs: 4096 | ||
| max-num-batched-tokens: 16384 | ||
| max-cudagraph-capture-size: 8192 | ||
|
|
||
| health_check: | ||
| max_attempts: 360 | ||
| interval_seconds: 10 | ||
|
|
||
| benchmark: | ||
| type: "sa-bench" | ||
| isl: 1024 | ||
| osl: 1024 | ||
| concurrencies: "4x16x64x128x4096" | ||
| req_rate: "inf" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.