fix(inference): apply quick-filter URL selections after mount#487
Merged
Conversation
…d pill hydration desync
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Small client-only state timing change in inference quick filters; no auth or data-path changes.
Overview
Fixes quick-filter pills (vendor, framework, agg/disagg, MTP/STP) staying visually wrong on shared links that include
i_vendor,i_fw,i_disagg, ori_spec.Those filters no longer read the query string in
useStateinitializers. They start empty so the first client render matches SSR, then a post-mountuseEffectparses the URL and applies any selections. Chart filtering from the URL still works; the pills’aria-pressed/ disabled state now stays in sync instead of freezing after a hydration mismatch.Reviewed by Cursor Bugbot for commit 3544fe9. Bugbot is set up for automated code reviews on this repo. Configure here.