Repository navigation
fix(windows): restore native build and runtime validation - #4581
Merged
Merged
Conversation
…into t3/cargo-acquisition-fix
`--strategy=TestRunner=dynamic` cannot execute `local` tests, so release packager gates fail before the fixture runs.
Clippy 1.99 denies large_futures on the four pending-stop wrappers.
Keep master's parallel job start and 4543's feature-gates body.
The hosted Windows workspace build exhausted its disk while linking test and benchmark binaries. fastbuild already uses debuginfo=0, but the Rust toolchain still declared a PDB for every executable and the MSVC fastbuild feature requested /DEBUG:FASTLINK. Bazel retained copies in its output tree and disk cache. Set the toolchain strip mode coherently so the declared outputs match rustc, and disable the MSVC PDB feature in the Windows CI config. Keep debug builds, unoptimized CI compilation, all targets, and test assertions intact. Failure evidence: https://github.com/ScriptedAlchemy/tracedecay/actions/runs/40262687638/job/121378315631
The generic cargo_bootstrap helper kills native provisioning after 600 seconds. Two cold hosted runs progressed through unique upstream dependencies until the cutoff: the latest compiled aws-config at 05:21:51 and aws-smithy-http-client at 05:22:08, then was killed at 05:22:30. It never reached workspace compilation or tests. Give the pinned optimized compiler build an explicit 30-minute budget within the existing 90-minute job. Keep the shared bootstrap artifacts, source checksum, locked dependency graph, and workspace test deadlines unchanged. This isolates the measured cold compiler cost from application test policy. Failure evidence: https://github.com/ScriptedAlchemy/tracedecay/actions/runs/40271873114/job/121406236336
Bazel 9.3.1 pins rules_cc 0.2.17. Its feature resolver rejects an unsupported feature that another enabled feature unconditionally implies; the MSVC fastbuild feature implies generate_pdb_file, so disabling only the latter causes an analysis error. Disable the C toolchain fastbuild feature for both target and exec configurations. Preserve its /Od and /INCREMENTAL:NO settings explicitly, while omitting /Z7 and /DEBUG:FASTLINK. The Rust compilation mode and opt/debug/strip mappings, CRT selection, explicit dbg feature, and every CI target remain unchanged. Verified against rules_cc 0.2.17 cc/private/toolchain_config/configure_features.bzl and cc/private/toolchain/windows_cc_toolchain_config.bzl, and Bazel 9.3.1 src/MODULE.tools and CppOptions.java. git diff --check passes; hosted Windows CI will validate the complete action graph.
The failing Windows job restored an 11,695,764,148-byte action-cache archive produced by master with full PDB generation, then exhausted D: with only 7 MB free. Its restore prefix does not include compiler or linker flags, so the new action keys would leave those obsolete CAS entries beside freshly built outputs. Move only the Windows action cache to ci-windows-test-v2 with no fallback to the former prefix. Repository and dependency caches, every build/test target, and the existing cache save/verification policy remain intact. Evidence: https://github.com/ScriptedAlchemy/tracedecay/actions/runs/40262687638/job/121378315631 and https://github.com/ScriptedAlchemy/tracedecay/actions/runs/40226853333/job/121314025643. Workflow YAML parsing and semantic comparison confirm that only the Windows cache generation changes; git diff --check passes.
# Conflicts: # .github/actions/setup-bazel/action.yml
# Conflicts: # .bazelrc # .github/workflows/ci.yml # MODULE.bazel
…ndows-native-validation # Conflicts: # .github/workflows/ci.yml # scripts/bazel/gen_builds.py
|
ScriptedAlchemy
marked this pull request as ready for review
October 27, 2026 04:18
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ScriptedAlchemy
enabled auto-merge (squash)
October 27, 2026 05:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Windows builds and tests exposed failures in repository identity, database writer recovery, hook admission, host bundle publication, and validation tooling. This change repairs those paths while preserving identity bytes, authorization checks, callback deadlines, and typed failures.
Based on the actual merged result of #4543, which supplies the Windows Bazel generator execution fix and Rust 1.99 toolchain.
Native Windows verification at
d19f0b0976:bazel build --config=ci-windows //... --jobs=8: all 451 targets passed.bazel test --config=ci-windows //... --test_output=errors --jobs=8: exit 0; 171 test targets passed, 2 skipped, no failures (167 executed; the remainder reused valid cached results).The developer machine is configured for native MSVC builds, Git Bash/runfiles, the pinned Rust and pnpm toolchains, and Python. Machine-specific paths and cache settings remain in local configuration. Hosted GitHub checks are running or queued separately, with no failures reported at the final local verification. The results above are from the native Windows machine.