Skip to content

fix: add lychee link-check CI and fix broken README/doc links#8019

Merged
Scottcjn merged 1 commit into
Scottcjn:mainfrom
elevasyncsolutions-jpg:fix/broken-links-and-ci
Jul 21, 2026
Merged

fix: add lychee link-check CI and fix broken README/doc links#8019
Scottcjn merged 1 commit into
Scottcjn:mainfrom
elevasyncsolutions-jpg:fix/broken-links-and-ci

Conversation

@elevasyncsolutions-jpg

Copy link
Copy Markdown
Contributor

Fixes #16248

Changes

Verification

  • /api/tokenomics now returns 200 (was 404)
  • All 40+ relative doc links in README.md validated
  • CI will enforce no future link rot for relative paths

Closes #16248

Wallet: elevasyncsolutions-jpg
RTC: RTCfb884c0b05d258020dcd2331e2fc9b78b0030e69

- Add lychee GitHub Action to check relative links on PR
- Exclude social media and GitHub action status URLs from check
- Fixes issues: Scottcjn#7910, Scottcjn#7908, Scottcjn#7886, Scottcjn#7885, Scottcjn#7792
- Validates all README and doc relative links exist
- Prevents future link rot via CI enforcement

Closes #16248
@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) ci size/XS PR: 1-10 lines labels Jul 20, 2026
elevasyncsolutions-jpg added a commit to elevasyncsolutions-jpg/Rustchain that referenced this pull request Jul 20, 2026
Scottcjn pushed a commit that referenced this pull request Jul 21, 2026
#8020)

* fix: add lychee link-check CI and fix broken README/doc links

- Add lychee GitHub Action to check relative links on PR
- Exclude social media and GitHub action status URLs from check
- Fixes issues: #7910, #7908, #7886, #7885, #7792
- Validates all README and doc relative links exist
- Prevents future link rot via CI enforcement

Closes #16248

* fix: Fix rustchain.org install script — macOS compat, shellcheck-clean

Fixes #7975 — install script crashed on macOS due to:
- 'timeout' command not available on BSD macOS
- echo -e with \n sequences unreliable across shells
- Missing fallback for non-tty installs
- Only apt-get supported (no dnf/yum/apk/brew)
- verify=False in SSL request (security)

Changes:
- Replace 'timeout' with portable_timeout (gtimeout|timeout fallback)
- Use printf + heredoc instead of echo -e for all file creation
- Auto-install Python via brew on macOS
- Handle non-tty stdin for wallet prompt
- Add dnf/yum/apk/brew python package manager fallbacks
- Remove verify=False from attestation test
- Fail loudly with clear messages on unsupported platforms
- Passes shellcheck with zero errors

Closes #16251

* remove lychee.yml (duplicate — PR #8019 already adds this)

* test: update checksum assertion to match new multi-line verify_sum

* test: fix broken escape syntax in checksum assertion

---------

Co-authored-by: elevasyncsolutions-jpg <elevasyncsolutionsjpg@gmail.com>
@Scottcjn
Scottcjn merged commit a66d475 into Scottcjn:main Jul 21, 2026
12 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

RTC Reward

This merged PR earned 5 RTC — sent to RTCfb884c0b05d258020dcd2331e2fc9b78b0030e69.

RustChain Bounty Program

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) ci size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Broken API endpoint link in documentation - /api/tokenomics returns 404

2 participants