Skip to content

openjdk: fix checkver for superseded release pages#587

Open
B67687 wants to merge 1 commit intoScoopInstaller:masterfrom
B67687:codex/openjdk-archive-checkver-fix
Open

openjdk: fix checkver for superseded release pages#587
B67687 wants to merge 1 commit intoScoopInstaller:masterfrom
B67687:codex/openjdk-archive-checkver-fix

Conversation

@B67687
Copy link
Copy Markdown

@B67687 B67687 commented Apr 9, 2026

Relates to #585

Summary

  • fix checkver for openjdk, openjdk17, and openjdk20 through openjdk25
  • switch those manifests from superseded jdk.java.net/<major> pages to https://jdk.java.net/archive/
  • keep the change scoped to manifests whose current pinned versions are still directly discoverable in the archive

Out of scope

  • openjdk18 and openjdk19 are still affected, but I left them out of this PR because the archive no longer exposes the exact versions those manifests currently point to (18.0.2.1-1 and 19.0.2-7)
  • those two look like separate follow-up work rather than a safe drop-in archive switch

Verification

  • checkver.ps1 bucket/openjdk.json -> 25.0.2-10
  • checkver.ps1 bucket/openjdk17.json -> 17.0.2-8
  • checkver.ps1 bucket/openjdk20.json -> 20.0.2-9
  • checkver.ps1 bucket/openjdk21.json -> 21.0.2-13
  • checkver.ps1 bucket/openjdk22.json -> 22.0.2-9
  • checkver.ps1 bucket/openjdk23.json -> 23.0.2-7
  • checkver.ps1 bucket/openjdk24.json -> 24.0.2-12
  • checkver.ps1 bucket/openjdk25.json -> 25.0.2-10

Summary by CodeRabbit

  • Chores
    • Updated OpenJDK version detection and verification configuration for all supported releases (versions 17-25). Modified how version information is retrieved by consolidating sources to use a centralized archive endpoint instead of individual release landing pages, enhancing consistency and reliability in automated version discovery.

@B67687
Copy link
Copy Markdown
Author

B67687 commented Apr 9, 2026

/verify

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 98096003-236d-40ff-805d-e5ee2b5e5f5f

📥 Commits

Reviewing files that changed from the base of the PR and between 45af0df and e35213e.

📒 Files selected for processing (8)
  • bucket/openjdk.json
  • bucket/openjdk17.json
  • bucket/openjdk20.json
  • bucket/openjdk21.json
  • bucket/openjdk22.json
  • bucket/openjdk23.json
  • bucket/openjdk24.json
  • bucket/openjdk25.json

Walkthrough

Multiple OpenJDK manifest files (versions 17, 20, 21, 22, 23, 24, 25) were updated to use a centralized archive endpoint (https://jdk.java.net/archive/) instead of version-specific landing pages. The regex patterns were updated correspondingly to match GA artifacts at the new download URL structure. The replace templates remain unchanged.

Changes

Cohort / File(s) Summary
OpenJDK Version Manifests
bucket/openjdk.json, bucket/openjdk17.json, bucket/openjdk20.json, bucket/openjdk21.json, bucket/openjdk22.json, bucket/openjdk23.json, bucket/openjdk24.json, bucket/openjdk25.json
Updated checkver.url from version-specific pages to centralized https://jdk.java.net/archive/ endpoint. Updated checkver.re regex patterns to match GA artifacts at https://download.java.net/java/GA/... with version-specific constraints and corrected file extension matching. Version extraction templates unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • Add openjdk25 #554: Directly modifies the same OpenJDK manifest files' checkver configuration, switching version detection from landing pages to the archive endpoint and updating regex patterns accordingly.

Suggested labels

review-needed

Suggested reviewers

  • se35710

Poem

🐰 Eight archives now converge in one blessed URL,
No more scattered pages, just a unified central pull!
With regex refined and patterns realigned,
OpenJDK versions march forward, perfectly designed. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: fixing checkver configuration for OpenJDK manifests to use the archive endpoint instead of superseded release pages.
Description check ✅ Passed The pull request description includes all required template elements: references a related issue (#585), confirms reading the Contributing Guide, provides a clear summary of changes, notes out-of-scope items, and includes verification steps with expected outputs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

All changes look good.

Wait for review from human collaborators.

openjdk

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

openjdk17

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

openjdk20

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

openjdk21

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

openjdk22

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

openjdk23

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

openjdk24

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

openjdk25

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant