zulufx25*: add version 25.32.21 (jdk and jre) #584
+76
−0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "description": "Open Source Builds of Zulu With OpenJFX", | ||
| "homepage": "https://www.azul.com/products/zulu-community/zulufx/", | ||
| "version": "25.32.21", | ||
| "license": { | ||
| "identifier": "GPL-2.0-only WITH Classpath-exception-2.0", | ||
| "url": "https://www.azulsystems.com/license/zulu_third_party_licenses.html" | ||
| }, | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://cdn.azul.com/zulu/bin/zulu25.32.21-ca-fx-jdk25.0.2-win_x64.zip", | ||
| "hash": "50d428552aef90f1f36117f68f03a7f52f63753ade454b1319ea4ae44b52ac19", | ||
| "extract_dir": "zulu25.32.21-ca-fx-jdk25.0.2-win_x64" | ||
| } | ||
| }, | ||
| "env_add_path": "bin", | ||
| "env_set": { | ||
| "JAVA_HOME": "$dir" | ||
| }, | ||
| "checkver": { | ||
| "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jdk&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1", | ||
| "jsonpath": "$..download_url", | ||
| "regex": "(?<name>zulu(?<version>[\\d.]+)-ca-fx-jdk(?<java>[\\d.]+)-win)_x64.zip", | ||
| "replace": "${version}" | ||
| }, | ||
| "autoupdate": { | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://cdn.azul.com/zulu/bin/$matchName_x64.zip", | ||
| "extract_dir": "$matchName_x64", | ||
| "hash": { | ||
| "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jdk&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1", | ||
| "jp": "$..sha256_hash" | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
Comment on lines
+26
to
+37
There was a problem hiding this comment. Critical: Empty The autoupdate hash URL has 🔧 Proposed fix- "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jdk&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1",
+ "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=25&os=windows&arch=x64&archive_type=zip&java_package_type=jdk&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1",As per the pattern in 🤖 Prompt for AI Agents✅ Confirmed as addressed by @minichiello There was a problem hiding this comment.
🧠 Learnings usedIf you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! |
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "description": "Open Source Builds of Zulu With OpenJFX", | ||
| "homepage": "https://www.azul.com/products/zulu-community/zulufx/", | ||
| "version": "25.32.21", | ||
| "license": { | ||
| "identifier": "GPL-2.0-only WITH Classpath-exception-2.0", | ||
| "url": "https://www.azulsystems.com/license/zulu_third_party_licenses.html" | ||
| }, | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://cdn.azul.com/zulu/bin/zulu25.32.21-ca-fx-jre25.0.2-win_x64.zip", | ||
| "hash": "4042b60589ef40e8d3bf38ae792e8143037ba6a39112ef88ca9ef7d2fa71b259", | ||
| "extract_dir": "zulu25.32.21-ca-fx-jre25.0.2-win_x64" | ||
| } | ||
| }, | ||
| "env_add_path": "bin", | ||
| "env_set": { | ||
| "JAVA_HOME": "$dir" | ||
| }, | ||
| "checkver": { | ||
| "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=25&os=windows&arch=x64&archive_type=zip&java_package_type=jre&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1", | ||
| "jsonpath": "$..download_url", | ||
| "regex": "(?<name>zulu(?<version>[\\d.]+)-ca-fx-jre(?<java>[\\d.]+)-win)_x64.zip", | ||
| "replace": "${version}" | ||
| }, | ||
minichiello marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "autoupdate": { | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://cdn.azul.com/zulu/bin/$matchName_x64.zip", | ||
| "extract_dir": "$matchName_x64", | ||
| "hash": { | ||
| "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=25&os=windows&arch=x64&archive_type=zip&java_package_type=jre&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1", | ||
| "jp": "$..sha256_hash" | ||
| } | ||
| } | ||
| } | ||
| } | ||
minichiello marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Empty
java_versionparameter will break version checking.The
checkverURL hasjava_version=(empty) at line 21, which will cause the Azul API call to fail or return incorrect results. Based on the version25.32.21and the pattern established inbucket/zulufx22-jdk.json, this should bejava_version=25.🔧 Proposed fix
As per the pattern in
bucket/zulufx22-jdk.json(lines 20-25), which usesjava_version=22for the corresponding Java 22 distribution.🤖 Prompt for AI Agents
✅ Confirmed as addressed by @minichiello
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "java_version=25"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minichiello, thanks for making the fix! Settingjava_version=25in thecheckverURL ensures the Azul API returns the correct results for the ZuluFX 25 distribution. 🎉🧠 Learnings used
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!