Features/aii/gtr 13556

[yuyixg]

No description provided.

[qodo-code-review]

Code Review by Qodo

Sorry, something went wrong

We weren't able to complete the code review on our side. Please try again manually by commenting /agentic_review on this PR.

[qodo-code-review]

PR Summary by Qodo

Prevent SharpCache agent memory growth and shared-result mutations

🐞 Bug fix 🧪 Tests 🕐 20-40 Minutes

AI Description

• Key cache entries by argument content so repeated agent queries reuse results instead of retaining
 copies.
• Keep per-instance entries with their service instances and copy shared results before
 request-specific changes.
• Add regression tests for cache retention, invalidation, key behavior, and caller isolation.

Diagram

graph TD
  Trigger["Rule triggers"] --> Service["Agent service"] --> Cache["SharpCache"] --> Shared[("Shared cache")] --> Copies["Copying callers"]
  Filter["AgentFilter key"] --> Cache
  Cache --> Instance[("Instance entries")]

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Canonical serialization for AgentFilter keys

• ➕ New filter fields would be included without manually extending GetCacheKey.
• ➕ Unambiguous encoding could reduce delimiter-related key collisions.
• ➖ Serialization and hashing add work to a frequent query path.
• ➖ Canonical handling of property and collection order would need an explicit policy.

Recommendation: Keep the content-key and instance-owned storage strategy: it addresses both sources of retained entries without changing agent query behavior. Consider unambiguous encoding for AgentFilter fields as a follow-up; its manually assembled key depends on delimiter assumptions.

Files changed (9) +611 / -24

Bug fix (6) +166 / -24

Agent.csExpose a complete shallow copy of Agent +6/-0

Expose a complete shallow copy of Agent

• Adds ShallowCopy for callers that must preserve every Agent member while replacing collections they intend to modify.

src/Infrastructure/BotSharp.Abstraction/Agents/Models/Agent.cs

SharpCacheAttribute.csUse content keys and instance-owned cache entries +119/-20

Use content keys and instance-owned cache entries

• Replaces identity-based argument keys with stable content representations and bypasses caching when a key cannot be produced. Moves per-instance entries to weakly associated storage, retains expiry, and clears those entries during cache invalidation.

src/Infrastructure/BotSharp.Abstraction/Infrastructures/SharpCacheAttribute.cs

AgentFilter.csGive AgentFilter a content-based cache key +16/-1

Give AgentFilter a content-based cache key

• Implements ICacheKey using pagination and every filter field so equivalent new filters can share agent-query results.

src/Infrastructure/BotSharp.Abstraction/Repositories/Filters/AgentFilter.cs

AgentService.GetAgents.csAvoid mutating the shared default LLM configuration +2/-1

Avoid mutating the shared default LLM configuration

• Clones the default LLM configuration before marking an agent's inherited configuration, leaving AgentSettings unchanged.

src/Infrastructure/BotSharp.Core/Agents/Services/AgentService.GetAgents.cs

RoutingAgentHook.csIsolate conversation-specific routable fields +14/-0

Isolate conversation-specific routable fields

• Copies routable agents and their field lists before removing fields already present in a conversation, preserving cached results for later conversations.

src/Infrastructure/BotSharp.Core/Routing/Hooks/RoutingAgentHook.cs

AgentController.csApply inheritance to a copy of the cached agent +9/-2

Apply inheritance to a copy of the cached agent

• Copies the fetched agent, its mutable collections, and routing rules before adding inherited items and resolving redirect names for the response.

src/Infrastructure/BotSharp.OpenAPI/Controllers/Agent/AgentController.cs

Tests (3) +445 / -0

BotSharp.Core.UnitTests.csprojReference OpenAPI from the core unit tests +2/-0

Reference OpenAPI from the core unit tests

• Adds the OpenAPI project reference so regression tests can exercise AgentController.

tests/BotSharp.Core.UnitTests/BotSharp.Core.UnitTests.csproj

SharpCacheAgentMemoryTests.csTest agent cache reuse and entry lifetime +312/-0

Test agent cache reuse and entry lifetime

• Exercises the woven agent service with fresh repository results to verify repeated filters reuse one entry, scoped entries are collectible and clearable, and default settings stay unchanged. Also checks argument-key behavior and retained memory.

tests/BotSharp.Core.UnitTests/Infrastructures/SharpCacheAgentMemoryTests.cs

SharpCacheSharedResultTests.csTest isolation of shared agent results +131/-0

Test isolation of shared agent results

• Verifies that routing one conversation does not remove another's cached fields and that an agent response does not add inherited items or redirect names to the cached agent.

tests/BotSharp.Core.UnitTests/Infrastructures/SharpCacheSharedResultTests.cs

[JackJiang1234]

reviewed