Skip to content

Add downstream ODE regression test for immutable-outer VectorOfArray #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Aug 3, 2026
Merged

Add downstream ODE regression test for immutable-outer VectorOfArray #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Downstream/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ ModelingToolkit = "8.33, 9, 10, 11"
MonteCarloMeasurements = "1.1"
NLsolve = "4"
OrdinaryDiffEq = "6.31, 7"
OrdinaryDiffEqRosenbrock = "1, 2"
OrdinaryDiffEqRosenbrock = "2.6.1"
StaticArrays = "1"
RecursiveArrayTools = "4"
RecursiveArrayToolsShorthandConstructors = "1"
Expand Down
21 changes: 20 additions & 1 deletion test/Downstream/odesolve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ end
AutoTsit5(Rodas5())
).retcode == ReturnCode.Success

@test_broken solve(
@test solve(
ODEProblem(
dyn,
ArrayPartition(
Expand All @@ -74,3 +74,22 @@ u = fill(SVector{2}(ones(2)), 2, 3)
ode = ODEProblem(rhs!, VectorOfArray(u), (0.0, 1.0))
sol = solve(ode, Tsit5())
@test successful_retcode(sol)

# VectorOfArray whose outer storage is itself immutable
function decay!(dQ, Q, p, t)
dQ[:, 1] .= @view Q[:, 1]
dQ[:, 2] .= @view Q[:, 2]
return nothing
end

u0 = [randn(5), randn(5)]
exact = reduce(hcat, u .* exp(1.0) for u in u0)
for alg in (Tsit5(), Rosenbrock23())
local Q = VectorOfArray(SVector{2}(deepcopy(u0)))
local sol = solve(
ODEProblem(decay!, Q, (0.0, 1.0)), alg, abstol = 1.0e-10, reltol = 1.0e-10
)
@test successful_retcode(sol)
@test sol.u[end] isa typeof(Q)
@test Array(sol.u[end]) ≈ exact rtol = 1.0e-5
end
Loading