Implicity convert function into FunctionWrappersWrapper#54
Open
densmojd wants to merge 4 commits into
Open
Conversation
…ameters are specified but only the function to be wrapped is provied as an argument.
…ng exp and cos of integer really doesn't make sense. Actually check the value of the wrapped cos.
…ed on new constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to implicitly convert a function into a
FunctionWrappersWrapper. Specific modifications include:FunctionWrappersWrapperouter constructor for when the type parameters are specified and only the function to be wrapped is provided as an argument, i.e.,FunctionWrappersWrapper{FW, P, CS}(f). Contrast this function with the existing outer constructor, where all parameters are provided as arguments.Base.convertforFunctionWrappersWrapperthat use the above constructor.These changes allow composite types with
FunctionWrappersWrapperfields to be constructed by providing the functions to be wrapped only. For example, one can construct aVector{FWW}using:for some concrete
FWW <: FunctionWrappersWrapper.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Closes #52