Skip to content

fix: allow filtering on metadata keys outside the capped list#2212

Merged
abdimo101 merged 4 commits intomasterfrom
allow-all-metadata-keys-conditions
Feb 9, 2026
Merged

fix: allow filtering on metadata keys outside the capped list#2212
abdimo101 merged 4 commits intomasterfrom
allow-all-metadata-keys-conditions

Conversation

@abdimo101
Copy link
Copy Markdown
Member

@abdimo101 abdimo101 commented Feb 4, 2026

Description

This PR removes validation that prevented users from adding scientific conditions for metadata keys that is not present in the limited metadataKeys list.

Motivation

Background on use case, changes needed

Fixes:

Please provide a list of the fixes implemented in this PR

  • Items added

Changes:

Please provide a list of the changes implemented by this PR

  • changes made

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Allow adding search conditions for metadata keys outside the predefined parameter list by relaxing frontend validation in the search parameters dialog.

Bug Fixes:

  • Remove client-side validation that incorrectly blocked selection of metadata keys not present in the limited parameterKeys list.

Tests:

  • Update Cypress dataset search test to expect the duplicate-field warning now that the invalid-field validation has been removed.

@abdimo101 abdimo101 requested a review from a team as a code owner February 4, 2026 11:17
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@abdimo101 abdimo101 requested a review from Junjiequan February 4, 2026 11:21
@abdimo101 abdimo101 merged commit be19f34 into master Feb 9, 2026
8 checks passed
@abdimo101 abdimo101 deleted the allow-all-metadata-keys-conditions branch February 9, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants