clarify: Explain why ternary operator correctly selects address family constants#2
Closed
Copilot wants to merge 1 commit intofeat/add_server_and_clientfrom
Closed
clarify: Explain why ternary operator correctly selects address family constants#2Copilot wants to merge 1 commit intofeat/add_server_and_clientfrom
Copilot wants to merge 1 commit intofeat/add_server_and_clientfrom
Conversation
Copilot
AI
changed the title
[WIP] Update comparison result usage in server/client implementation
clarify: Explain why ternary operator correctly selects address family constants
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses question about why comparison results shouldn't be used directly in socket address family assignment.
Context
The code uses a ternary operator to select between
AF_INET6(10) andAF_INET(2):Clarification
strcmp(...) == 0yields 0 or 1, which don't matchAF_INET(2) orAF_INET6(10)The distinction matters because socket APIs require specific constant values, not boolean results.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.