Open
Conversation
naoto-iwase
reviewed
Dec 30, 2025
Comment on lines
+61
to
+64
| index = 0 | ||
| zero_count = 0 | ||
| nums_len = len(nums) | ||
| while index + zero_count < nums_len: |
There was a problem hiding this comment.
indexをnon_zero_countと命名するとループ継続条件がより明快になりそうです。
あるいは、indexは必ずindex + zero_countの形でしか使わないのでこれをindexやiとする方が自然に感じます。
Owner
Author
There was a problem hiding this comment.
その書き方の人は確かにちらほら見かけましたね、ご意見ありがとうございます
nodchip
reviewed
Dec 31, 2025
| non_zero_indices.append(i) | ||
|
|
||
| nums_non_zero = len(non_zero_indices) | ||
| for i in range(nums_len): |
There was a problem hiding this comment.
nums[i] = nums[non_zero_indices[i]]を行うループと、
nums[i] = 0を行うループに分けたほうがシンプルだと思いました。
oda
reviewed
Jan 3, 2026
|
|
||
| ## Step 3. Final Solution | ||
|
|
||
| - 一番シンプルに感じたもので実装 |
There was a problem hiding this comment.
特に問題ないかと思います。
erase remove idiom を連想したので調べておいてください。
tokuhirat
reviewed
Jan 5, 2026
| continue | ||
| nums[non_zero_count], nums[i] = nums[i], nums[non_zero_count] | ||
| non_zero_count += 1 | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題：https://leetcode.com/problems/move-zeroes/description/