Skip to content

chore(deps): update linting to v10 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SamuelIVX wants to merge 1 commit into from
Closed

chore(deps): update linting to v10 #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@
"use": "^3.1.1"
},
"devDependencies": {
"@eslint/js": "^9.17.0",
"@eslint/js": "^10.0.0",
"@tailwindcss/postcss": "^4.2.2",
"@types/react": "^18.3.18",
"@types/react-dom": "^18.3.5",
"@vitejs/plugin-react": "^5.0.0",
"autoprefixer": "^10.4.20",
"eslint": "^9.17.0",
"eslint": "^10.0.0",
"eslint-plugin-react": "^7.37.2",
"eslint-plugin-react-hooks": "^7.0.0",
Comment on lines +32 to 40

@coderabbitai coderabbitai Bot May 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify published peer dependency support for eslint-plugin-react
# (read-only; no repo access required)
set -euo pipefail

npm view eslint version
npm view eslint-plugin-react version
npm view eslint-plugin-react peerDependencies --json
npm view eslint-plugin-react@latest peerDependencies --json

Repository: SamuelIVX/SamuelIVX.github.io

Length of output: 205

Peer dependency conflict blocks npm install with ESLint 10

Lines 32, 38 upgrade ESLint to ^10.0.0, but eslint-plugin-react@7.37.2 (Line 39) has peer dependency "eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9.7", which explicitly excludes v10. This creates a hard ERESOLVE failure and blocks the PR.

Either downgrade ESLint to ^9.7 or upgrade eslint-plugin-react to a v8+ version that supports ESLint 10.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` around lines 32 - 40, The PR upgrades "eslint" to ^10.0.0 but
"eslint-plugin-react"@7.37.2 declares a peer dependency excluding v10, causing
ERESOLVE; fix package.json by either downgrading the "eslint" entry to ^9.7
(restore compatibility) or upgrading "eslint-plugin-react" to a v8+ release that
declares support for ESLint 10 (update the "eslint-plugin-react" version string
accordingly), then run npm install and verify no peer dependency conflicts
remain.

"eslint-plugin-react-refresh": "^0.5.0",
Expand Down
Loading