FADPCM decoder #15
Open
FADPCM decoder #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: LongerWarrior <37636768+longerwarrior@users.noreply.github.com>
ds5678
suggested changes
Jan 15, 2026
|
|
||
| int outIndex = frameBaseOutIndex + ((i * 32 + j * 8 + k) * numChannels); | ||
|
|
||
| if (outIndex < outputSpan.Length) |
| internal static sbyte GetLowNibbleSigned(byte value) => SignedNibbles[value & 0xF]; | ||
| internal static short Clamp(short val, short min, short max) => Math.Max(Math.Min(val, max), min); | ||
|
|
||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] |
Contributor
There was a problem hiding this comment.
The .NET runtime team recommends you never do this unless you benchmark to verify that it actually improves performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FADPCM decoder based on vgmstream implementation - I've added necessary vgmstream notice but wasn't sure where I should put it so feel free to change it however it suits you.
I've tried to optimize it the best I could. Tested on soundbanks from Rennsport, Dragon Khan Demo.
I hope you're still active @SamboyCoding and can review this :(