LFS: beta rules toggle + severity filter on the Flows page#723
Open
RubenHalman wants to merge 1 commit into
Open
LFS: beta rules toggle + severity filter on the Flows page#723RubenHalman wants to merge 1 commit into
RubenHalman wants to merge 1 commit into
Conversation
Two new options in the Flows section powered by the Lightning Flow Scanner integration.
- Added a checkbox to include/exclude beta rules in the scan. Toggling it busts the dataset cache so flows are re-scanned with the right ruleset.
- Added a severity dropdown (All / Errors only / Warnings & above / Notes & above). Filtering on severity re-mixes already-cached data, so no extra API calls to Salesforce.
On the data side, lfsViolations now stores { name, severity } objects instead of plain strings, which is what makes the severity filter possible. Updated secretsauce formulas and table column definitions accordingly.
Collaborator
|
I really appreciate the time you put in this PR. Don't you think that this option would complexify the app? I would prefer you to tell me which is the best options we can put by default in the app. By experience the less option i set in the app the better. Users in the end do not get the impact on changing the options, and finally set all options to true and launch the scanning... So it's maybe better to come up with a default setting that would be the same one for everyone. what do you think? and maybe if they want to go deeper in the analysis they can use directly LFS directly?! Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @VinceFINET 👋
Two small quality-of-life improvements for the Lightning Flow Scanner integration on the Flows page.
What's in here
Beta rules toggle
Added a checkbox in the Flows section to include or exclude LFS beta rules. When you flip it, the flows dataset cache is busted and the scan reruns with the updated ruleset — so you always get results for the right set of rules without having to hit the global refresh button.
Severity filter
Added a dropdown next to the checkbox: All severities / Errors only / Warnings & above / Notes & above. Since the violations are already stored after the scan, changing the filter just re-mixes the cached data — no extra calls to Salesforce.
Under the hood
To make the severity filter work,
lfsViolationshad to change fromstring[]to{ name, severity }[]. That touched a few places:.includes('X')to.some(v => v.name === 'X')valueupdated from'.'to'name'mapResults()in the LFS scanner now captures severity from each rule resultThe
betaModeflag flows through the stack viaDatasetRunInformationparameters, and both options are part ofmixDependencies()so the cache stamp changes correctly when either value changes.Testing notes