fix(components/molecule/accordion): fix accordion in iOS Safari 26.4#2969
Merged
Conversation
stivaliserna
requested review from
andresin87,
andresz1,
kikoruiz and
sui-bot
as code owners
|
kikoruiz
approved these changes
Apr 14, 2026
crFront
approved these changes
Apr 14, 2026
…ded to prevent popover clipping
|
andresin87
approved these changes
Apr 16, 2026
Member
|
super! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category/Component
❓ AskDescription, Motivation and Context
Fix accordion rendering issues in iOS Safari ≥26.4 by replacing
max-heightanimations with a grid-based approach (grid-template-rows: 0fr → 1fr).This avoids known WebKit repaint bugs with
overflow: hiddeninside scroll containers and ensures correct layout flow (siblings are pushed down properly).Adds required constraints (
min-height: 0andoverflow: hidden) to allow proper collapsing behavior.Types of changes
Screenshots - Animations
Before
safari-bug-1.mov
safari-bug-2.mov
safari-bug-3.mov
After
safari-fix-1.mov
safari-fix-2.mov
safari-fix-3.mov