Skip to content

Fix(databricks): Bugfix for get correct datatypes from information_schema table #5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuffbyYuki merged 6 commits into from
May 28, 2026
+3 −2
Merged

Fix(databricks): Bugfix for get correct datatypes from information_schema table #5816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
11a563b
Updated databricks adapter to use information_schema to get data-type…
MisterWheatley May 1, 2026
e0580b8
Updated code and added unit test
MisterWheatley May 5, 2026
9682bd5
Minor refactor and adding mocked current catalog to unit test
MisterWheatley May 5, 2026
55b4acb
Merge branch 'main' into fix_databricks_column_types
MisterWheatley May 26, 2026
c6991da
Merge branch 'SQLMesh:main' into fix_databricks_column_types
MisterWheatley May 28, 2026
212393d
Fixed wrong call signature for cursor.fetchall and updated unit test
MisterWheatley May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sqlmesh/core/engine_adapter/databricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,7 @@ def columns(
.order_by("ordinal_position ASC")
)

result = self.cursor.fetchall(query)
self.cursor.execute(query)
result = self.cursor.fetchall()

return {row[0]: exp.DataType.build(row[1], dialect=self.dialect) for row in result}
2 changes: 1 addition & 1 deletion tests/core/engine_adapter/test_databricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ def test_columns(mocker: MockFixture, make_mocked_engine_adapter: t.Callable):
),
}

adapter.cursor.fetchall.assert_called_once_with(
adapter.cursor.execute.assert_called_once_with(
parse_one(
"""SELECT columns.column_name, columns.full_data_type FROM system.information_schema.columns WHERE table_name = 'test_table' AND table_schema = 'test_db' AND table_catalog = 'test_catalog' ORDER BY ordinal_position ASC""",
dialect="databricks",
Expand Down
Loading