Repository navigation
test(laya): compare the unrouted mixture answer within 1e-6 - #535
Merged
Merged
Conversation
The routed and unrouted calls are not bit-identical (about 2e-9), so the exact comparison failed intermittently, including on develop at the 0.64.2 merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LayaExpertSyntheticTest.a_mixture_routes_overrides_and_compares_as_specifiedcompared the routed and unrouted answers for exact equality. The two differ by about 2e-9, which is why Build & Test failed ondevelopat the 0.64.2 merge (b4f9789) and blocks the tag.Checked locally: before the change the test failed 6 of 9 runs. After it, 12 of 12 pass, and the full
:llm-inference:laya:jvmTestpasses.🤖 Generated with Claude Code