Open
Conversation
Collaborator
|
Fixes made in astrodb_utils v1.3 to make this possible. |
Collaborator
|
schema updated in #674 to work with astrodb_utils functions. |
kelle
reviewed
Mar 4, 2026
| }, | ||
| { | ||
| "instrument": "IMACS", | ||
| "mode": "Missing", |
Collaborator
There was a problem hiding this comment.
Can mode be null instead of "Missing"?
Member
Author
There was a problem hiding this comment.
Looks like mode is set nullable as false in schema so it cannot be null in instrument table.
Collaborator
There was a problem hiding this comment.
let's change these "Missing"s to "spectroscopy"
Collaborator
|
For the 14 sources, are the spectral types easily findable somewhere in the Zhang papers? |
Collaborator
|
We also need to double check the discovery references for these 14 new sources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description: Fix simple.yaml to add mode as PK in spectra table and JSON ingestion for Zhang18.
Link to relevant issue: Closes #
For data ingests: