Open
Conversation
NicholasLe04
requested changes
Mar 20, 2025
Comment on lines
+59
to
+62
| except sqlite3.Error as e: | ||
| if(isinstance(e,ConnectionError)): | ||
| raise ConnectionError(f"Error when connecting to database: {str(e)}") | ||
| raise DatabaseError(f"Database error when fetching snack {sku}: {str(e)}") |
Contributor
There was a problem hiding this comment.
I think you can do something like this which makes it more readable
Suggested change
| except sqlite3.Error as e: | |
| if(isinstance(e,ConnectionError)): | |
| raise ConnectionError(f"Error when connecting to database: {str(e)}") | |
| raise DatabaseError(f"Database error when fetching snack {sku}: {str(e)}") | |
| except ConnectionError as e: | |
| raise ConnectionError(f"Error when connecting to database: {str(e)}") | |
| except Exception as e: | |
| raise DatabaseError(f"Database error when fetching snack {sku}: {str(e)}") |
backend/utils/db.py
Outdated
Comment on lines
+102
to
+115
| if not isinstance(snack.sku, str): | ||
| raise RecordNotFoundError(f"{snack.sku} is not a string") | ||
| if not isinstance(snack.name, str): | ||
| raise RecordNotFoundError(f"{snack.name} is not a string") | ||
| if not isinstance(snack.quantity, int): | ||
| raise RecordNotFoundError(f"{snack.quantity} is not an int") | ||
| if not isinstance(snack.price, float): | ||
| raise RecordNotFoundError(f"{snack.price} is not a float") | ||
| if not isinstance(snack.description, str): | ||
| raise RecordNotFoundError(f"{snack.description} is not a string") | ||
| if not isinstance(snack.category, str): | ||
| raise RecordNotFoundError(f"{snack.category} is not a string") | ||
| if not isinstance(snack.photo_url, str): | ||
| raise RecordNotFoundError(f"{snack.photo_url} is not a string") |
Contributor
There was a problem hiding this comment.
I don't think we need to check the types here because the Pydantic models should be handling that for us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
error handling for db