Partially Addressed Error Handling for API Route#17
Partially Addressed Error Handling for API Route#17MatthewTran22 wants to merge 2 commits intodevfrom
Conversation
NicholasLe04
left a comment
There was a problem hiding this comment.
left some comments/suggestions!
| except Exception as e: | ||
| raise_internal_error() |
There was a problem hiding this comment.
this is catching an exception then raising another exception which isn't caught. perhaps we can change this so that the exception is caught. (maybe we raise it in the try block instead of the catch block?)
| except Exception as e: | ||
| raise_internal_error() |
There was a problem hiding this comment.
this is catching an exception then raising another exception which isn't caught. perhaps we can change this so that the exception is caught. (maybe we raise it in the try block instead of the catch block?)
| except Exception as e: | ||
| raise_internal_error() |
There was a problem hiding this comment.
this is catching an exception then raising another exception which isn't caught. perhaps we can change this so that the exception is caught. (maybe we raise it in the try block instead of the catch block?)
| except Exception as e: | ||
| raise_internal_error() No newline at end of file |
There was a problem hiding this comment.
this is catching an exception then raising another exception which isn't caught. perhaps we can change this so that the exception is caught. (maybe we raise it in the try block instead of the catch block?)
Some parts, like the check for duplicates or input validation, don't have dedicated methods.
Input validation only checks if the SKU isn't empty
Checking for duplicates is not implemented, so the error handling is not created yet
All other cases are handled