Fixing ADC-> e- calibration in blip data processing#939
Conversation
|
The caloAlg parameters for MC and Data should be the following Data Prior to this PR Since fhicl-dump still runs without issue and the parameters seem appropriately updated, no further validations were performed. |
|
Hi @Jjm321814, I just wanted to check if you want this merged soon? I plan to cut a new integration release this week and I can try to have this in if you'd like. If so, then I would reach out to Miquel for a review. |
|
This isn't an urgent merge but should be good to do whenever. I'll get the changes from develop merged in later today and add Miquel as a reviewer too. |
|
Sounds good, thanks @Jjm321814 . I saw that Miquel is already added as a reviewer. I would just reach out to him if you want this PR merged soon. It sounds like it isn't urgent though, so no rush. We can merge it into the next release as well. |
reco2_data did not update the blipreco or blipana ADC->e- calibration constant, and just applied the MC value.
With this PR the data is scaled by the appropriate calibration data.
This should improve data-MC agreement by ~4% and will not impact production or performance in any meaningful way.