Skip to content

Workaround to silence dangling reference warning. #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hgreenlee wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Workaround to silence dangling reference warning. #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cebf883
Workaround to silence dangling reference warning.
hgreenlee Sep 2, 2026
d850e7e
Get rid of pragmas.
hgreenlee Sep 2, 2026
86ddb23
Remove redundant/incorrect default constructor argument.
hgreenlee Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sbncode/OpT0Finder/flashmatch/Algorithms/ChargeAnalytical.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

#include "ChargeAnalytical.h"

#pragma GCC diagnostic ignored "-Wdangling-reference"

namespace flashmatch {

static ChargeAnalyticalFactory __global_ChargeAnalyticalFactory__;
Expand Down
2 changes: 0 additions & 2 deletions sbncode/OpT0Finder/flashmatch/Algorithms/LightPath.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

#include "LightPath.h"

#pragma GCC diagnostic ignored "-Wdangling-reference"

namespace flashmatch {

static LightPathFactory __global_LightPathFactory__;
Expand Down
2 changes: 0 additions & 2 deletions sbncode/OpT0Finder/flashmatch/Algorithms/QLLMatch.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

#include "QLLMatch.h"

#pragma GCC diagnostic ignored "-Wdangling-reference"

using namespace std::chrono;
namespace flashmatch {

Expand Down
7 changes: 5 additions & 2 deletions sbncode/OpT0Finder/flashmatch/Base/FMWKInterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,18 @@ namespace flashmatch {
class DetectorSpecs {

public:
DetectorSpecs(std::string filename="specs.cfg");
DetectorSpecs() = delete;
DetectorSpecs(std::string filename);
~DetectorSpecs(){}

inline static DetectorSpecs& GetME(std::string filename="detector_specs.cfg")
inline static DetectorSpecs& GetME(std::string filename)
{
if(!_me) _me = new DetectorSpecs(filename);
return *_me;
}

inline static DetectorSpecs& GetME() { return GetME("detector_specs.cfg"); }

/// PMT XYZ position filler
inline const geoalgo::Point_t& PMTPosition(size_t opch) { return _pmt_v.at(opch); }

Expand Down